Skip to content

Fix incompatibilities with pre-OAuth2 version of Server Manager - #1820

Merged
isc-klu merged 13 commits into
intersystems-community:masterfrom
isc-klu:support-old-server-manager
Aug 10, 2026
Merged

Fix incompatibilities with pre-OAuth2 version of Server Manager#1820
isc-klu merged 13 commits into
intersystems-community:masterfrom
isc-klu:support-old-server-manager

Conversation

@isc-klu

@isc-klu isc-klu commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Enable strictNullChecks and fix a Server Manager compatibility bug

Functional changes

  • [src/api/index.ts] / [src/extension.ts]: Patch ServerManagerAPI for compatibility with pre-OAuth2 versions of Server Manager:
    • Construct a BasicAuthorization when Server Manager doesn't supply an auth object.
    • Fall back to the server name when getServerSpec doesn't set name on the returned spec.
  • [src/extension.ts]: Expose username and password on ObjectScriptAPI.serverForUri.
  • [tsconfig.base.json]: Enable strictNullChecks, so mistakes like the ones above get caught by the compiler instead of at runtime.

Non-functional changes

Everything else is mechanical fallout from enabling strictNullChecks, limited to:

  • Adding a missing type annotation.
  • Loosening a type annotation to include undefined/null where that reflects actual runtime behavior.
  • Adding non-null assertions (!) to values of which the type is nullable.

No behavior changes outside the items listed above.

@isc-klu
isc-klu requested a review from isc-bsaviano as a code owner August 7, 2026 19:40
@isc-klu isc-klu self-assigned this Aug 7, 2026
@isc-klu isc-klu changed the title Support Server Manager before 3.14.0 Fix incompatibilities with older version of Server Manager Aug 7, 2026
@isc-klu isc-klu changed the title Fix incompatibilities with older version of Server Manager Fix incompatibilities with pre-OAuth2 version of Server Manager Aug 7, 2026
@isc-klu
isc-klu merged commit e031512 into intersystems-community:master Aug 10, 2026
5 checks passed
@isc-klu
isc-klu deleted the support-old-server-manager branch August 10, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants